Re: [PATCH v3 04/16] os-posix: Clean up global variable shadowing

[Eric Blake]

On Wed, Oct 04, 2023 at 02:00:07PM +0200, Philippe Mathieu-Daudé wrote:
> Fix:
> 
>   os-posix.c:103:31: error: declaration shadows a variable in the global 
> scope [-Werror,-Wshadow]
>   bool os_set_runas(const char *optarg)
>                                 ^
>   os-posix.c:176:32: error: declaration shadows a variable in the global 
> scope [-Werror,-Wshadow]
>   void os_set_chroot(const char *optarg)
>                                  ^
>   
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14:
>  note: previous declaration is here
>   extern char *optarg;                    /* getopt(3) external variables */
>                ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/sysemu/os-posix.h |  4 ++--
>  os-posix.c                | 12 ++++++------
>  2 files changed, 8 insertions(+), 8 deletions(-)
>

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org