Re: [RFC PATCH v2 1/9] Add Rust SEV library as subproject

[Tyler Fanelli]

On 10/5/23 2:03 AM, Philippe Mathieu-Daudé wrote:
> Hi Tyler,
>
> On 4/10/23 22:34, Tyler Fanelli wrote:
> > The Rust sev library provides a C API for the AMD SEV launch ioctls, as
> > well as the ability to build with meson. Add the Rust sev library as a
> > QEMU subproject with the goal of outsourcing all SEV launch ioctls to C
> > APIs provided by it.
> >
> > Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
> > ---
> >   meson.build                   | 8 ++++++++
> >   meson_options.txt             | 2 ++
> >   scripts/meson-buildoptions.sh | 3 +++
> >   subprojects/sev.wrap          | 6 ++++++
> >   target/i386/meson.build       | 2 +-
> >   5 files changed, 20 insertions(+), 1 deletion(-)
> >   create mode 100644 subprojects/sev.wrap
>
>
> > diff --git a/subprojects/sev.wrap b/subprojects/sev.wrap
> > new file mode 100644
> > index 0000000000..5be1faccf6
> > --- /dev/null
> > +++ b/subprojects/sev.wrap
> > @@ -0,0 +1,6 @@
> > +[wrap-git]
> > +url = https://github.com/tylerfanelli/sev
> > +revision = b81b1da5df50055600a5b0349b0c4afda677cccb
>
> Why use your tree instead of the mainstream one?
>
> Before this gets merged we need to mirror the subproject
> on our GitLab namespace, then use the mirror URL here.
Hi Philippe,

Why must the subproject be mirrored on qemu's GitLab namespace? With the 
changes being accepted in the upstream sev repository, meson will be 
able to fetch it from there. I see that libblkio (another Rust project) 
is not mirrored in the GitLab namespace [0] (assuming I'm looking in the 
right place) and that meson also fetches it from its upstream repo [1].

[0] https://gitlab.com/qemu-project

[1] 
https://gitlab.com/qemu-project/qemu/-/blob/master/subprojects/libblkio.wrap?ref_type=heads#L2


Tyler