qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] migration/multifd: Clarify Error usage in multifd_channe


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/3] migration/multifd: Clarify Error usage in multifd_channel_connect
Date: Thu, 12 Oct 2023 15:53:23 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1

On 12/10/23 15:43, Fabiano Rosas wrote:
The function is currently called from two sites, one always gives it a
NULL Error and the other always gives it a non-NULL Error.

In the non-NULL case, all it does it trace the error and return. One
of the callers already have tracing, add a tracepoint to the other and
stop passing the error into the function.

Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
  migration/multifd.c    | 60 ++++++++++++++++++++----------------------
  migration/trace-events |  3 ++-
  2 files changed, 30 insertions(+), 33 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]