[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 41/83] timer/i8254: Fix one shot PIT mode
From: |
Michael S. Tsirkin |
Subject: |
[PULL 41/83] timer/i8254: Fix one shot PIT mode |
Date: |
Wed, 18 Oct 2023 11:56:26 -0400 |
From: Damien Zammit <damien@zamaudio.com>
Currently, the one-shot (mode 1) PIT expires far too quickly,
due to the output being set under the wrong logic.
This change fixes the one-shot PIT mode to behave similarly to mode 0.
TESTED: using the one-shot PIT mode to calibrate a local apic timer.
Signed-off-by: Damien Zammit <damien@zamaudio.com>
Message-Id: <20230226015755.52624-1-damien@zamaudio.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/timer/i8254_common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/timer/i8254_common.c b/hw/timer/i8254_common.c
index e4093e2904..b25da448c8 100644
--- a/hw/timer/i8254_common.c
+++ b/hw/timer/i8254_common.c
@@ -52,10 +52,8 @@ int pit_get_out(PITChannelState *s, int64_t current_time)
switch (s->mode) {
default:
case 0:
- out = (d >= s->count);
- break;
case 1:
- out = (d < s->count);
+ out = (d >= s->count);
break;
case 2:
if ((d % s->count) == 0 && d != 0) {
--
MST
- [PULL 18/83] tests: bios-tables-test: Add test for smbios type4 core count, (continued)
- [PULL 18/83] tests: bios-tables-test: Add test for smbios type4 core count, Michael S. Tsirkin, 2023/10/18
- [PULL 20/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core count2 test, Michael S. Tsirkin, 2023/10/18
- [PULL 21/83] tests: bios-tables-test: Extend smbios core count2 test to cover general topology, Michael S. Tsirkin, 2023/10/18
- [PULL 28/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count2 test, Michael S. Tsirkin, 2023/10/18
- [PULL 24/83] tests: bios-tables-test: Add test for smbios type4 thread count, Michael S. Tsirkin, 2023/10/18
- [PULL 27/83] tests: bios-tables-test: Add test for smbios type4 thread count2, Michael S. Tsirkin, 2023/10/18
- [PULL 19/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 core count test, Michael S. Tsirkin, 2023/10/18
- [PULL 32/83] vhost-user: flatten "enforce_reply" into "vhost_user_write_sync", Michael S. Tsirkin, 2023/10/18
- [PULL 33/83] vhost-user: hoist "write_sync", "get_features", "get_u64", Michael S. Tsirkin, 2023/10/18
- [PULL 36/83] memory: initialize 'fv' in MemoryRegionCache to make Coverity happy, Michael S. Tsirkin, 2023/10/18
- [PULL 41/83] timer/i8254: Fix one shot PIT mode,
Michael S. Tsirkin <=
- [PULL 42/83] hw/display: fix memleak from virtio_add_resource, Michael S. Tsirkin, 2023/10/18
- [PULL 40/83] hw/i386/acpi-build: Remove build-time assertion on PIIX/ICH9 reset registers being identical, Michael S. Tsirkin, 2023/10/18
- [PULL 44/83] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge, Michael S. Tsirkin, 2023/10/18
- [PULL 48/83] hw/i386/pc_piix: Remove redundant "piix3" variable, Michael S. Tsirkin, 2023/10/18
- [PULL 29/83] vhost-user: strip superfluous whitespace, Michael S. Tsirkin, 2023/10/18
- [PULL 37/83] vhost-user: do not send RESET_OWNER on device reset, Michael S. Tsirkin, 2023/10/18
- [PULL 51/83] hw/isa/piix3: Wire PIC IRQs to ISA bus in host device, Michael S. Tsirkin, 2023/10/18
- [PULL 50/83] hw/i386/pc_q35: Wire ICH9 LPC function's interrupts before its realize(), Michael S. Tsirkin, 2023/10/18
- [PULL 52/83] hw/i386/pc: Wire RTC ISA IRQs in south bridges, Michael S. Tsirkin, 2023/10/18
- [PULL 22/83] tests: bios-tables-test: Update ACPI table binaries for smbios core count2 test, Michael S. Tsirkin, 2023/10/18