[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 3/6] target/riscv: Remove misa_mxl validation
From: |
Akihiko Odaki |
Subject: |
[PATCH v5 3/6] target/riscv: Remove misa_mxl validation |
Date: |
Thu, 19 Oct 2023 19:10:25 +0900 |
It is initialized with a simple assignment and there is little room for
error. In fact, the validation is even more complex.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
target/riscv/tcg/tcg-cpu.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c
index a28918ab30..7f45e42000 100644
--- a/target/riscv/tcg/tcg-cpu.c
+++ b/target/riscv/tcg/tcg-cpu.c
@@ -148,7 +148,7 @@ static void riscv_cpu_validate_misa_priv(CPURISCVState
*env, Error **errp)
}
}
-static void riscv_cpu_validate_misa_mxl(RISCVCPU *cpu, Error **errp)
+static void riscv_cpu_validate_misa_mxl(RISCVCPU *cpu)
{
RISCVCPUClass *mcc = RISCV_CPU_GET_CLASS(cpu);
CPUClass *cc = CPU_CLASS(mcc);
@@ -168,11 +168,6 @@ static void riscv_cpu_validate_misa_mxl(RISCVCPU *cpu,
Error **errp)
default:
g_assert_not_reached();
}
-
- if (env->misa_mxl_max != env->misa_mxl) {
- error_setg(errp, "misa_mxl_max must be equal to misa_mxl");
- return;
- }
}
static void riscv_cpu_validate_priv_spec(RISCVCPU *cpu, Error **errp)
@@ -573,11 +568,7 @@ static bool tcg_cpu_realize(CPUState *cs, Error **errp)
return false;
}
- riscv_cpu_validate_misa_mxl(cpu, &local_err);
- if (local_err != NULL) {
- error_propagate(errp, local_err);
- return false;
- }
+ riscv_cpu_validate_misa_mxl(cpu);
riscv_cpu_validate_priv_spec(cpu, &local_err);
if (local_err != NULL) {
--
2.42.0
- [PATCH v5 0/6] gdbstub and TCG plugin improvements, Akihiko Odaki, 2023/10/19
- [PATCH v5 1/6] gdbstub: Check if gdb_regs is NULL, Akihiko Odaki, 2023/10/19
- [PATCH v5 2/6] hw/riscv: Use misa_mxl instead of misa_mxl_max, Akihiko Odaki, 2023/10/19
- [PATCH v5 3/6] target/riscv: Remove misa_mxl validation,
Akihiko Odaki <=
- [PATCH v5 4/6] target/riscv: Move misa_mxl_max to class, Akihiko Odaki, 2023/10/19
- [PATCH v5 5/6] target/riscv: Validate misa_mxl_max only once, Akihiko Odaki, 2023/10/19
- [PATCH v5 6/6] plugins: Remove an extra parameter, Akihiko Odaki, 2023/10/19