[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/11] tests/aio: Clean up global variable shadowing
From: |
Thomas Huth |
Subject: |
[PULL 07/11] tests/aio: Clean up global variable shadowing |
Date: |
Fri, 27 Oct 2023 11:37:06 +0200 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Rename the argument to fix:
tests/unit/test-aio.c:130:44: error: declaration shadows a variable in the
global scope [-Werror,-Wshadow]
static void set_event_notifier(AioContext *ctx, EventNotifier *notifier,
^
tests/unit/test-aio.c:22:20: note: previous declaration is here
static AioContext *ctx;
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231009100251.56019-9-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/unit/test-aio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/unit/test-aio.c b/tests/unit/test-aio.c
index 71ed31a4db..337b6e4ea7 100644
--- a/tests/unit/test-aio.c
+++ b/tests/unit/test-aio.c
@@ -127,10 +127,10 @@ static void *test_acquire_thread(void *opaque)
return NULL;
}
-static void set_event_notifier(AioContext *ctx, EventNotifier *notifier,
+static void set_event_notifier(AioContext *nctx, EventNotifier *notifier,
EventNotifierHandler *handler)
{
- aio_set_event_notifier(ctx, notifier, handler, NULL, NULL);
+ aio_set_event_notifier(nctx, notifier, handler, NULL, NULL);
}
static void dummy_notifier_read(EventNotifier *n)
--
2.41.0
- [PULL 00/11] testing patches (+ 1 deprecation patch), Thomas Huth, 2023/10/27
- [PULL 03/11] tests/virtio-scsi: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 02/11] tests/throttle: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 04/11] tests/cdrom-test: Clean up global variable shadowing in prepare_image(), Thomas Huth, 2023/10/27
- [PULL 05/11] tests/rtl8139: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 01/11] system/qtest: Clean up global variable shadowing in qtest_server_init(), Thomas Huth, 2023/10/27
- [PULL 07/11] tests/aio: Clean up global variable shadowing,
Thomas Huth <=
- [PULL 06/11] tests/npcm7xx_adc: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 08/11] tests/coroutine: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 09/11] docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated, Thomas Huth, 2023/10/27
- [PULL 10/11] tests/vm/freebsd: Add additional library paths for libfdt, Thomas Huth, 2023/10/27
- [PULL 11/11] ipmi-bt-test: force ipv4, Thomas Huth, 2023/10/27
- Re: [PULL 00/11] testing patches (+ 1 deprecation patch), Stefan Hajnoczi, 2023/10/30