qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-9.0 06/11] hw/arm/bcm2836: Simplify use of 'reset-cbar' p


From: Richard Henderson
Subject: Re: [PATCH-for-9.0 06/11] hw/arm/bcm2836: Simplify use of 'reset-cbar' property
Date: Tue, 28 Nov 2023 08:03:32 -0600
User-agent: Mozilla Thunderbird

On 11/22/23 12:30, Philippe Mathieu-Daudé wrote:
bcm2836_realize() is called by

  - bcm2836_class_init() which sets:

     bc->cpu_type = ARM_CPU_TYPE_NAME("cortex-a7")

  - bcm2837_class_init() which sets:

     bc->cpu_type = ARM_CPU_TYPE_NAME("cortex-a53")

Both Cortex-A7 / A53 have the ARM_FEATURE_CBAR set. If it isn't,
then this is a programming error: use &error_abort.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]