Re: [PATCH] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off

[Philippe Mathieu-Daudé]

On 30/11/23 19:39, Taylor Simpson wrote:
> Adding -Werror=shadow=compatible-local causes Hexagon not to build
> when idef-parser is off.  The "label" variable in CHECK_NOSHUF_PRED
> shadows a variable in the surrounding code.
>
> Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
> ---
>   target/hexagon/macros.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
> index 9a51b5709b..f99390e2a8 100644
> --- a/target/hexagon/macros.h
> +++ b/target/hexagon/macros.h
> @@ -93,13 +93,13 @@
>   
>   #define CHECK_NOSHUF_PRED(GET_EA, SIZE, PRED) \
>       do { \
> -        TCGLabel *label = gen_new_label(); \
> -        tcg_gen_brcondi_tl(TCG_COND_EQ, PRED, 0, label); \
> +        TCGLabel *noshuf_label = gen_new_label(); \
> +        tcg_gen_brcondi_tl(TCG_COND_EQ, PRED, 0, noshuf_label); \

Fragile, but sufficient.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>