Re: [PATCH v6 2/4] qcow2: add configurations for zoned format extension

[Markus Armbruster]

Sam Li <faithilikerun@gmail.com> writes:

> Markus Armbruster <armbru@redhat.com> 于2023年11月30日周四 09:40写道：
>>
>> Sam Li <faithilikerun@gmail.com> writes:

[...]

>> > +##
>> > +# @Qcow2ZoneHostManaged:
>> > +#
>> > +# The host-managed zone model.  It only allows sequential writes.
>> > +#
>> > +# @size: Total number of bytes within zones
>> > +#
>> > +# @capacity: The number of usable logical blocks within zones
>> > +#     in bytes.  A zone capacity is always smaller or equal to the
>> > +#     zone size
>> > +#
>> > +# @conventional-zones: The number of conventional zones of the
>> > +#     zoned device
>> > +#
>> > +# @max-open-zones: The maximal number of open zones
>> > +#
>> > +# @max-active-zones: The maximal number of zones in the implicit
>> > +#     open, explicit open or closed state
>> > +#
>> > +# @max-append-bytes: The maximal number of bytes of a zone
>> > +#     append request that can be issued to the device.  It must be
>> > +#     512-byte aligned
>>
>> Missing period at the end.
>>
>> For all the optional members: what's the default?
>
> The default for optional members is 0. When max-open-zones and
> max-active-zones are 0, it implies no limit on zone resources.

Please document the default in the doc comment.  We commonly do it like
this:

      # @max-open-zones: The maximal number of open zones (default 0)

[...]