Re: [PATCH 22/22] target/i386: implement CMPccXADD

[Richard Henderson]

On 12/23/23 05:16, Paolo Bonzini wrote:
> +    case JCC_S:
> +        cmp_lhs = s->T0, cmp_rhs = tcg_constant_tl(0);
> +        break;

I think you need an sextract here, when ot != full word size, same as JCC_O.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~