qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 12/33] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 12/33] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init
Date: Tue, 2 Jan 2024 20:12:12 +0100
User-agent: Mozilla Thunderbird

On 2/1/24 02:57, Richard Henderson wrote:
The size of the allocation need not match the alignment.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  hw/tpm/tpm_ppi.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/tpm/tpm_ppi.c b/hw/tpm/tpm_ppi.c
index 7f74e26ec6..91eeafd53a 100644
--- a/hw/tpm/tpm_ppi.c
+++ b/hw/tpm/tpm_ppi.c
@@ -47,8 +47,7 @@ void tpm_ppi_reset(TPMPPI *tpmppi)
  void tpm_ppi_init(TPMPPI *tpmppi, MemoryRegion *m,
                    hwaddr addr, Object *obj)
  {
-    tpmppi->buf = qemu_memalign(qemu_real_host_page_size(),
-                                HOST_PAGE_ALIGN(TPM_PPI_ADDR_SIZE));
+    tpmppi->buf = qemu_memalign(qemu_real_host_page_size(), TPM_PPI_ADDR_SIZE);
      memory_region_init_ram_device_ptr(&tpmppi->ram, obj, "tpm-ppi",
                                        TPM_PPI_ADDR_SIZE, tpmppi->buf);
      vmstate_register_ram(&tpmppi->ram, DEVICE(obj));

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]