Re: [PATCH 4/9] intc/grlib_irqmp: implements multicore irq

[Philippe Mathieu-Daudé]

On 5/1/24 11:24, Clément Chigot wrote:
> Now there is an ncpus property, use it in order to deliver the IRQ to
> multiple CPU.
>
> Co-developed-by: Frederic Konrad <konrad.frederic@yahoo.fr>
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
>   hw/intc/grlib_irqmp.c         | 43 ++++++++++++++++++-----------------
>   hw/sparc/leon3.c              |  3 ++-
>   include/hw/intc/grlib_irqmp.h |  2 +-
>   3 files changed, 25 insertions(+), 23 deletions(-)


> diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
> index 7b9809b81f..94d8ec94b0 100644
> --- a/hw/sparc/leon3.c
> +++ b/hw/sparc/leon3.c
> @@ -168,7 +168,8 @@ static void leon3_cache_control_int(CPUSPARCState *env)
>   
>   static void leon3_irq_ack(void *irq_manager, int intno)
>   {
> -    grlib_irqmp_ack((DeviceState *)irq_manager, intno);
> +    /* No SMP support yet.  */
> +    grlib_irqmp_ack((DeviceState *)irq_manager, 0, intno);

This '0' was not obvious, now I figured, I suggest:

      /* No SMP support yet, only CPU #0 available so far. */

>   }