Re: [PATCH 21/40] vdpa: vhost_vdpa_dma_batch_end_once rename

[Jason Wang]

On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu <si-wei.liu@oracle.com> wrote:
>
> No functional changes. Rename only.
>
> Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
>  hw/virtio/vhost-vdpa.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 47c764b..013bfa2 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -191,7 +191,7 @@ static void 
> vhost_vdpa_iotlb_batch_begin_once(VhostVDPAShared *s)
>      s->iotlb_batch_begin_sent = true;
>  }
>
> -static void vhost_vdpa_dma_end_batch(VhostVDPAShared *s)
> +static void vhost_vdpa_dma_batch_end_once(VhostVDPAShared *s)
>  {
>      struct vhost_msg_v2 msg = {};
>      int fd = s->device_fd;
> @@ -229,7 +229,7 @@ static void vhost_vdpa_listener_commit(MemoryListener 
> *listener)
>  {
>      VhostVDPAShared *s = container_of(listener, VhostVDPAShared, listener);
>
> -    vhost_vdpa_dma_end_batch(s);
> +    vhost_vdpa_dma_batch_end_once(s);
>  }
>
>  static void vhost_vdpa_iommu_map_notify(IOMMUNotifier *n, IOMMUTLBEntry 
> *iotlb)
> @@ -1367,7 +1367,7 @@ static void *vhost_vdpa_load_map(void *opaque)
>              vhost_vdpa_iotlb_batch_begin_once(shared);
>              break;
>          case VHOST_IOTLB_BATCH_END:
> -            vhost_vdpa_dma_end_batch(shared);
> +            vhost_vdpa_dma_batch_end_once(shared);

It's better to explain why having a "_once" suffix is better here.

Thanks

>              break;
>          default:
>              error_report("Invalid IOTLB msg type %d", msg->iotlb.type);
> --
> 1.8.3.1
>