[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] acpi/tests/avocado/bits: wait for 200 seconds for SHUTDOW
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2] acpi/tests/avocado/bits: wait for 200 seconds for SHUTDOWN event from bits VM |
Date: |
Fri, 19 Jan 2024 09:58:01 +0000 |
On Wed, 17 Jan 2024 at 09:43, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Wed, Jan 17, 2024 at 09:55:56AM +0530, Ani Sinha wrote:
> > By default, the timeout to receive any specified event from the QEMU VM is
> > 60
> > seconds set by the python avocado test framework. Please see event_wait()
> > and
> > events_wait() in python/qemu/machine/machine.py. If the matching event is
> > not
> > triggered within that interval, an asyncio.TimeoutError is generated. Since
> > the
> > timeout for the bits avocado test is 200 secs, we need to make event_wait()
> > timeout of the same value as well so that an early timeout is not triggered
> > by
> > the avocado framework.
> >
> > CC: peter.maydell@linaro.org
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2077
> > Signed-off-by: Ani Sinha <anisinha@redhat.com>
> > ---
> > tests/avocado/acpi-bits.py | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > changelog:
> > v2: cosmetic comment updates in code and patch description.
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Thanks; I've applied this directly. Hopefully it will deal with
this intermittent for good.
-- PMM