[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 8/8] linux-user/elfload: check PR_GET_DUMPABLE before creating cor
From: |
Richard Henderson |
Subject: |
[PULL 8/8] linux-user/elfload: check PR_GET_DUMPABLE before creating coredump |
Date: |
Sun, 21 Jan 2024 11:20:47 +1100 |
From: Thomas Weißschuh <thomas@t-8ch.de>
A process can opt-out of coredump creation by calling
prctl(PR_SET_DUMPABLE, 0).
linux-user passes this call from the guest through to the
operating system.
>From there it can be read back again to avoid creating coredumps from
qemu-user itself if the guest chose so.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Message-Id: <20240120-qemu-user-dumpable-v3-2-6aa410c933f1@t-8ch.de>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index c596871938..daf7ef8435 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2,6 +2,7 @@
#include "qemu/osdep.h"
#include <sys/param.h>
+#include <sys/prctl.h>
#include <sys/resource.h>
#include <sys/shm.h>
@@ -4667,6 +4668,11 @@ static int elf_core_dump(int signr, const CPUArchState
*env)
init_note_info(&info);
errno = 0;
+
+ if (prctl(PR_GET_DUMPABLE) == 0) {
+ return 0;
+ }
+
if (getrlimit(RLIMIT_CORE, &dumpsize) == 0 && dumpsize.rlim_cur == 0) {
return 0;
}
--
2.34.1
- [PULL 0/8] tcg + linux-user patch queue, Richard Henderson, 2024/01/20
- [PULL 1/8] tcg: Remove unreachable code, Richard Henderson, 2024/01/20
- [PULL 2/8] tcg: Make the cleanup-on-error path unique, Richard Henderson, 2024/01/20
- [PULL 3/8] linux-user: Fixed cpu restore with pc 0 on SIGBUS, Richard Henderson, 2024/01/20
- [PULL 4/8] tcg/s390x: Fix encoding of VRIc, VRSa, VRSc insns, Richard Henderson, 2024/01/20
- [PULL 5/8] tests/tcg/s390x: Import linux tools/testing/crypto/chacha20-s390, Richard Henderson, 2024/01/20
- [PULL 6/8] linux-user/riscv: Adjust vdso signal frame cfa offsets, Richard Henderson, 2024/01/20
- [PULL 7/8] linux-user/elfload: test return value of getrlimit, Richard Henderson, 2024/01/20
- [PULL 8/8] linux-user/elfload: check PR_GET_DUMPABLE before creating coredump,
Richard Henderson <=
- Re: [PULL 0/8] tcg + linux-user patch queue, Michael Tokarev, 2024/01/21
- Re: [PULL 0/8] tcg + linux-user patch queue, Peter Maydell, 2024/01/22