[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead ass
From: |
Brian Cain |
Subject: |
[PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead assignment |
Date: |
Sun, 21 Jan 2024 22:35:01 -0800 |
This is intended to address a coverity finding: CID 1527408.
Signed-off-by: Brian Cain <bcain@quicinc.com>
Reviewed-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Message-Id: <20240114234453.4114587-1-bcain@quicinc.com>
---
target/hexagon/mmvec/decode_ext_mmvec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/hexagon/mmvec/decode_ext_mmvec.c
b/target/hexagon/mmvec/decode_ext_mmvec.c
index 174eb3b78b..202d84c7c0 100644
--- a/target/hexagon/mmvec/decode_ext_mmvec.c
+++ b/target/hexagon/mmvec/decode_ext_mmvec.c
@@ -33,7 +33,6 @@ check_new_value(Packet *pkt)
const char *dststr = NULL;
uint16_t def_opcode;
char letter;
- int def_regnum;
for (i = 1; i < pkt->num_insns; i++) {
uint16_t use_opcode = pkt->insn[i].opcode;
@@ -78,7 +77,6 @@ check_new_value(Packet *pkt)
}
}
if ((dststr == NULL) && GET_ATTRIB(def_opcode, A_CVI_GATHER)) {
- def_regnum = 0;
pkt->insn[i].regno[use_regidx] = def_oreg;
pkt->insn[i].new_value_producer_slot = pkt->insn[def_idx].slot;
} else {
@@ -86,7 +84,7 @@ check_new_value(Packet *pkt)
/* still not there, we have a bad packet */
g_assert_not_reached();
}
- def_regnum = pkt->insn[def_idx].regno[dststr - reginfo];
+ int def_regnum = pkt->insn[def_idx].regno[dststr - reginfo];
/* Now patch up the consumer with the register number */
pkt->insn[i].regno[use_regidx] = def_regnum ^ def_oreg;
/* special case for (Vx,Vy) */
--
2.25.1
- [PULL 00/15] target-hexagon queue, hexagon docker, Brian Cain, 2024/01/22
- [PULL 05/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos, Brian Cain, 2024/01/22
- [PULL 03/15] Hexagon (target/hexagon) Clean up handling of modifier registers, Brian Cain, 2024/01/22
- [PULL 07/15] Hexagon (target/hexagon) Make generators object oriented - gen_idef_parser_funcs, Brian Cain, 2024/01/22
- [PULL 02/15] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off, Brian Cain, 2024/01/22
- [PULL 08/15] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs, Brian Cain, 2024/01/22
- [PULL 13/15] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions), Brian Cain, 2024/01/22
- [PULL 09/15] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs, Brian Cain, 2024/01/22
- [PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead assignment,
Brian Cain <=
- [PULL 01/15] tests/docker: Hexagon toolchain update, Brian Cain, 2024/01/22
- [PULL 10/15] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute, Brian Cain, 2024/01/22
- [PULL 14/15] Hexagon (target/hexagon) Remove old dectree.py, Brian Cain, 2024/01/22
- [PULL 12/15] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions), Brian Cain, 2024/01/22
- [PULL 04/15] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs, Brian Cain, 2024/01/22
- [PULL 06/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_funcs, Brian Cain, 2024/01/22
- [PULL 11/15] Hexagon (target/hexagon) Remove dead functions from hex_common.py, Brian Cain, 2024/01/22
- Re: [PULL 00/15] target-hexagon queue, hexagon docker, Peter Maydell, 2024/01/23