Re: [PATCH 4/6] hw/scsi/virtio-scsi: Use RCU_READ macro

[Philippe Mathieu-Daudé]

On 24/1/24 10:17, Manos Pitsidianakis wrote:
> On Wed, 24 Jan 2024 09:41, Philippe Mathieu-Daudé <philmd@linaro.org> 
> wrote:
> > Replace the manual rcu_read_(un)lock calls by the
> > WITH_RCU_READ_LOCK_GUARD macro (See commit ef46ae67ba
> > "docs/style: call out the use of GUARD macros").
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > hw/scsi/virtio-scsi.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)

> Unrelated to your patch: I just noticed in hw/scsi/virtio-scsi.c, 
> s->resetting is used to flag whether the bus is resetting; but there's 
> no check if a resetting is taking place before starting another. Is this 
> single threaded code so it's not necessary?

No clue about this device, I'll let the maintainers answer you :)