Re: [PATCH v3 0/5] hw/arm/aspeed: Check for CPU types in machine_run_board_init()

[Cédric Le Goater]

On 1/25/24 06:55, Philippe Mathieu-Daudé wrote:
> Series fully reviewed.

There is not much in the aspeed queue apart from [1]. I will consider
sending a PR after a review (Reviewers please ?). Anyhow, if you need
this series soon, feel free to take it.

Thanks,

C.


[1] 20240109173538.435781-1-clg@kaod.org/">https://lore.kernel.org/qemu-devel/20240109173538.435781-1-clg@kaod.org/


> Since v2:
> - Addressed Gavin & Richard review comments.
> - Collected R-b tags
>
> Since v1:
> - Follow suggestions from Cédric from [*]
>
> [*] 
> e13c655b-7904-4e47-a673-4efd13c26b3d@kaod.org/">https://lore.kernel.org/qemu-devel/e13c655b-7904-4e47-a673-4efd13c26b3d@kaod.org/
>
> Based-on: <20240123222508.13826-1-philmd@linaro.org>
>
> Philippe Mathieu-Daudé (5):
>    hw/arm/aspeed: Remove dead code
>    hw/arm/aspeed: Set default CPU count using aspeed_soc_num_cpus()
>    hw/arm/aspeed: Init CPU defaults in a common helper
>    hw/arm/aspeed: Introduce aspeed_soc_cpu_type() helper
>    hw/arm/aspeed: Check for CPU types in machine_run_board_init()
>
>   include/hw/arm/aspeed_soc.h |  4 ++-
>   hw/arm/aspeed.c             | 70 +++++++++++++++----------------------
>   hw/arm/aspeed_ast10x0.c     |  8 +++--
>   hw/arm/aspeed_ast2400.c     | 15 ++++++--
>   hw/arm/aspeed_ast2600.c     |  9 +++--
>   hw/arm/aspeed_soc_common.c  |  8 +++++
>   6 files changed, 65 insertions(+), 49 deletions(-)