qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam


From: Ninad Palsule
Subject: Re: [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam
Date: Fri, 26 Jan 2024 04:08:29 -0600
User-agent: Mozilla Thunderbird

Hello Cedric,


+#include "hw/fsi/fsi.h"
+
+#include "hw/qdev-properties.h"
+
+#define ENGINE_CONFIG_NEXT            BE_BIT(0)

BE_BIT is not used much. I wonder if we should keep it.
Agree. It is only used at couple of places. Removed BE_BIT()

Anyhow,


Reviewed-by: Cédric Le Goater <clg@kaod.org>

Added tag. Thanks for the review.

Regards,

Ninad





reply via email to

[Prev in Thread] Current Thread [Next in Thread]