Re: [PATCH] Make 'uri' optional for migrate QAPI

[Michael Tokarev]

23.01.2024 09:42, Het Gala:
> 'uri' argument should be optional, as 'uri' and 'channels'
> arguments are mutally exclusive in nature.
>
> Fixes: 074dbce5fcce (migration: New migrate and
> migrate-incoming argument 'channels')
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
>   qapi/migration.json | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index eb2f883513..197d3faa43 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1757,7 +1757,7 @@
>   #
>   ##
>   { 'command': 'migrate',
> -  'data': {'uri': 'str',
> +  'data': {'*uri': 'str',
>              '*channels': [ 'MigrationChannel' ],
>              '*blk': { 'type': 'bool', 'features': [ 'deprecated' ] },
>              '*inc': { 'type': 'bool', 'features': [ 'deprecated' ] },

This seems like a stable material too, - please let me know if it is not.

Thanks,

/mjt