[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/23] migration/multifd: Drop stale comment for multifd zero
From: |
peterx |
Subject: |
[PATCH v2 01/23] migration/multifd: Drop stale comment for multifd zero copy |
Date: |
Fri, 2 Feb 2024 18:28:35 +0800 |
From: Peter Xu <peterx@redhat.com>
We've already done that with multifd_flush_after_each_section, for multifd
in general. Drop the stale "TODO-like" comment.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/multifd.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 25cbc6dc6b..eee2586770 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -598,17 +598,6 @@ int multifd_send_sync_main(void)
}
}
- /*
- * When using zero-copy, it's necessary to flush the pages before any of
- * the pages can be sent again, so we'll make sure the new version of the
- * pages will always arrive _later_ than the old pages.
- *
- * Currently we achieve this by flushing the zero-page requested writes
- * per ram iteration, but in the future we could potentially optimize it
- * to be less frequent, e.g. only after we finished one whole scanning of
- * all the dirty bitmaps.
- */
-
flush_zero_copy = migrate_zero_copy_send();
for (i = 0; i < migrate_multifd_channels(); i++) {
--
2.43.0
- [PATCH v2 00/23] migration/multifd: Refactor ->send_prepare() and cleanups, peterx, 2024/02/02
- [PATCH v2 01/23] migration/multifd: Drop stale comment for multifd zero copy,
peterx <=
- [PATCH v2 02/23] migration/multifd: multifd_send_kick_main(), peterx, 2024/02/02
- [PATCH v2 03/23] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths, peterx, 2024/02/02
- [PATCH v2 04/23] migration/multifd: Postpone reset of MultiFDPages_t, peterx, 2024/02/02
- [PATCH v2 05/23] migration/multifd: Drop MultiFDSendParams.normal[] array, peterx, 2024/02/02
[PATCH v2 06/23] migration/multifd: Separate SYNC request with normal jobs, peterx, 2024/02/02