[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 47/61] hw/riscv/virt.c: use g_autofree in create_fdt_virtio()
From: |
Alistair Francis |
Subject: |
[PULL 47/61] hw/riscv/virt.c: use g_autofree in create_fdt_virtio() |
Date: |
Fri, 9 Feb 2024 20:57:59 +1000 |
From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Put 'name' declaration inside the loop, with g_autofree, to avoid
manually doing g_free() in each iteration.
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240122221529.86562-6-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
hw/riscv/virt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index d0f402e0d5..f8278df83f 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -820,12 +820,12 @@ static void create_fdt_virtio(RISCVVirtState *s, const
MemMapEntry *memmap,
uint32_t irq_virtio_phandle)
{
int i;
- char *name;
MachineState *ms = MACHINE(s);
for (i = 0; i < VIRTIO_COUNT; i++) {
- name = g_strdup_printf("/soc/virtio_mmio@%lx",
+ g_autofree char *name = g_strdup_printf("/soc/virtio_mmio@%lx",
(long)(memmap[VIRT_VIRTIO].base + i * memmap[VIRT_VIRTIO].size));
+
qemu_fdt_add_subnode(ms->fdt, name);
qemu_fdt_setprop_string(ms->fdt, name, "compatible", "virtio,mmio");
qemu_fdt_setprop_cells(ms->fdt, name, "reg",
@@ -840,7 +840,6 @@ static void create_fdt_virtio(RISCVVirtState *s, const
MemMapEntry *memmap,
qemu_fdt_setprop_cells(ms->fdt, name, "interrupts",
VIRTIO_IRQ + i, 0x4);
}
- g_free(name);
}
}
--
2.43.0
- [PULL 40/61] target/riscv: Validate misa_mxl_max only once, (continued)
- [PULL 40/61] target/riscv: Validate misa_mxl_max only once, Alistair Francis, 2024/02/09
- [PULL 42/61] target/riscv: Use RISCVException as return type for all csr ops, Alistair Francis, 2024/02/09
- [PULL 54/61] target/riscv: support new isa extension detection devicetree properties, Alistair Francis, 2024/02/09
- [PULL 60/61] target/riscv/cpu.c: add riscv_bare_cpu_init(), Alistair Francis, 2024/02/09
- [PULL 32/61] target/riscv: change vext_get_vlmax() arguments, Alistair Francis, 2024/02/09
- [PULL 34/61] target/riscv/cpu.c: remove cpu->cfg.vlen, Alistair Francis, 2024/02/09
- [PULL 41/61] target/riscv: FCSR doesn't contain vxrm and vxsat, Alistair Francis, 2024/02/09
- [PULL 43/61] hw/riscv/virt-acpi-build.c: fix leak in build_rhct(), Alistair Francis, 2024/02/09
- [PULL 44/61] hw/riscv/numa.c: use g_autofree in socket_fdt_write_distance_matrix(), Alistair Francis, 2024/02/09
- [PULL 57/61] target/riscv: SMBIOS support for RISC-V virt machine, Alistair Francis, 2024/02/09
- [PULL 47/61] hw/riscv/virt.c: use g_autofree in create_fdt_virtio(),
Alistair Francis <=
- [PULL 51/61] target/riscv: Check 'A' and split extensions for atomic instructions, Alistair Francis, 2024/02/09
- [PULL 53/61] target/riscv: use misa_mxl_max to populate isa string rather than TARGET_LONG_BITS, Alistair Francis, 2024/02/09
- [PULL 56/61] smbios: function to set default processor family, Alistair Francis, 2024/02/09
- [PULL 58/61] qemu-options: enable -smbios option on RISC-V, Alistair Francis, 2024/02/09
- [PULL 50/61] target/riscv: Add Zaamo and Zalrsc extension infrastructure, Alistair Francis, 2024/02/09
- Re: [PULL 00/61] riscv-to-apply queue, Peter Maydell, 2024/02/12