Re: [RFC PATCH v5 08/22] target/arm: Handle IS/FS in ISR_EL1 for NMI

[Richard Henderson]

On 2/29/24 03:10, Jinjie Ruan via wrote:
>       if (hcr_el2 & HCR_FMO) {
>           if (cs->interrupt_request & CPU_INTERRUPT_VFIQ) {
>               ret |= CPSR_F;
> +
> +            if (env->cp15.hcrx_el2 & HCRX_VFNMI) {
> +                ret |= ISR_FS;
> +            }

VFIO can be raised one of two ways: from the GIC and from HCR_EL2.VF.
But superpriority can only be added with HCRX_EL2.VFNMI.

You need to verify that HCR_EL2.VF is set before checking VFNMI.


r~