qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 05/19] contrib/elf2dmp: Fix error reporting style in addrs


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 05/19] contrib/elf2dmp: Fix error reporting style in addrspace.c
Date: Thu, 7 Mar 2024 11:25:59 +0100
User-agent: Mozilla Thunderbird

On 7/3/24 11:20, Akihiko Odaki wrote:
include/qapi/error.h says:
We recommend
* bool-valued functions return true on success / false on failure,
...

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
  contrib/elf2dmp/addrspace.h |  4 ++--
  contrib/elf2dmp/addrspace.c |  8 ++++----
  contrib/elf2dmp/main.c      | 47 +++++++++++++++++++++------------------------
  3 files changed, 28 insertions(+), 31 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]