qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/s390x: Include missing 'cpu.h' header


From: Thomas Huth
Subject: Re: [PATCH] hw/s390x: Include missing 'cpu.h' header
Date: Mon, 25 Mar 2024 12:01:57 +0100
User-agent: Mozilla Thunderbird

On 22/03/2024 17.28, Philippe Mathieu-Daudé wrote:
"cpu.h" is implicitly included. Include it explicitly to
avoid the following error when refactoring headers:

   hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier 
'TARGET_PAGE_SIZE'
       len = sac->peek_stattr(sas, addr / TARGET_PAGE_SIZE, buflen, vals);
                                          ^
   hw/s390x/s390-stattrib.c:94:58: error: use of undeclared identifier 
'TARGET_PAGE_MASK'
                      addr / TARGET_PAGE_SIZE, len, addr & ~TARGET_PAGE_MASK);
                                                          ^
   hw/s390x/s390-stattrib.c:224:40: error: use of undeclared identifier 
'TARGET_PAGE_BITS'
           qemu_put_be64(f, (start_gfn << TARGET_PAGE_BITS) | STATTR_FLAG_MORE);
                                          ^
   In file included from hw/s390x/s390-virtio-ccw.c:17:
   hw/s390x/s390-virtio-hcall.h:22:27: error: unknown type name 'CPUS390XState'
   int s390_virtio_hypercall(CPUS390XState *env);
                             ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  hw/s390x/s390-virtio-hcall.h | 2 ++
  hw/s390x/s390-stattrib.c     | 1 +
  2 files changed, 3 insertions(+)


Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]