[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 12/12] hw/mem/cxl_type3: Allow to release extent superset
From: |
Jonathan Cameron |
Subject: |
Re: [PATCH v6 12/12] hw/mem/cxl_type3: Allow to release extent superset in QMP interface |
Date: |
Fri, 5 Apr 2024 13:33:03 +0100 |
On Mon, 25 Mar 2024 12:02:30 -0700
nifan.cxl@gmail.com wrote:
> From: Fan Ni <fan.ni@samsung.com>
>
> Before the change, the QMP interface used for add/release DC extents
> only allows to release an extent whose DPA range is contained by a single
> accepted extent in the device.
>
> With the change, we relax the constraints. As long as the DPA range of
> the extent is covered by accepted extents, we allow the release.
>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
Nice.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> hw/mem/cxl_type3.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
> index 2628a6f50f..62c2022477 100644
> --- a/hw/mem/cxl_type3.c
> +++ b/hw/mem/cxl_type3.c
> @@ -1935,8 +1935,7 @@ static void qmp_cxl_process_dynamic_capacity(const char
> *path, CxlEventLog log,
> "cannot release extent with pending DPA range");
> return;
> }
> - if (!cxl_extents_contains_dpa_range(&dcd->dc.extents,
> - dpa, len)) {
> + if (!ct3_test_region_block_backed(dcd, dpa, len)) {
> error_setg(errp,
> "cannot release extent with non-existing DPA
> range");
> return;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v6 12/12] hw/mem/cxl_type3: Allow to release extent superset in QMP interface,
Jonathan Cameron <=