Re: [PATCH v3 05/27] util/hexdump: Inline g_string_append

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x"

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x"
Date:	Fri, 12 Apr 2024 19:43:45 +0200
User-agent:	Mozilla Thunderbird

On 12/4/24 09:33, Richard Henderson wrote:

Trivial arithmetic can be used for emitting the nibbles,
rather than full-blown printf formatting.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  util/hexdump.c | 12 +++++++++++-
  1 file changed, 11 insertions(+), 1 deletion(-)


Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 08/27] hw/scsi/scsi-disk: Use qemu_hexdump_line to avoid sprintf, (continued)
- [PATCH v3 08/27] hw/scsi/scsi-disk: Use qemu_hexdump_line to avoid sprintf, Richard Henderson, 2024/04/12
  - Re: [PATCH v3 08/27] hw/scsi/scsi-disk: Use qemu_hexdump_line to avoid sprintf, Philippe Mathieu-Daudé, 2024/04/12
- [PATCH v3 12/27] disas/m68k: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 13/27] disas/microblaze: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 15/27] target/microblaze: Re-indent print_insn_microblaze, Richard Henderson, 2024/04/12
- [PATCH v3 14/27] disas/microblaze: Split out print_immval_addr, Richard Henderson, 2024/04/12
- [PATCH v3 16/27] disas/microblaze: Merge op->name output into each fprintf, Richard Henderson, 2024/04/12
- [PATCH v3 11/27] backends/tpm: Use qemu_hexdump_line to avoid sprintf, Richard Henderson, 2024/04/12
  - Re: [PATCH v3 11/27] backends/tpm: Use qemu_hexdump_line to avoid sprintf, Philippe Mathieu-Daudé, 2024/04/12
- [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x", Richard Henderson, 2024/04/12
  - Re: [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x", Philippe Mathieu-Daudé <=
- [PATCH v3 17/27] disas/microblaze: Print registers directly with PRIreg, Richard Henderson, 2024/04/12
- [PATCH v3 23/27] hw/misc/imx: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 18/27] disas/microblaze: Print immediates directly with PRIimm, Richard Henderson, 2024/04/12
- [PATCH v3 26/27] target/arm: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 22/27] linux-user/flatload: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
  - Re: [PATCH v3 22/27] linux-user/flatload: Replace sprintf() by snprintf(), Peter Maydell, 2024/04/12
- [PATCH v3 21/27] disas/riscv: Use GString in format_inst, Richard Henderson, 2024/04/12
- [PATCH v3 25/27] hw/riscv/virt: Replace sprintf by g_strdup_printf, Richard Henderson, 2024/04/12
- [PATCH v3 19/27] disas/microblaze: Print registers directly with PRIrfsl, Richard Henderson, 2024/04/12
- [PATCH v3 20/27] disas/microblaze: Split get_field_special, Richard Henderson, 2024/04/12

Prev by Date: Re: [PATCH v3 04/27] util/hexdump: Add unit_len and block_len to qemu_hexdump_line
Next by Date: Re: [PATCH v3 07/27] system/qtest: Replace sprintf by qemu_hexdump_line
Previous by thread: [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x"
Next by thread: [PATCH v3 17/27] disas/microblaze: Print registers directly with PRIreg
Index(es):
- Date
- Thread