Re: [PATCH-for-9.0? 01/21] host/atomic128: Include missing 'qemu/atomic.h' header

[Philippe Mathieu-Daudé]

On 21/3/24 18:05, Richard Henderson wrote:
> On 3/21/24 05:48, Philippe Mathieu-Daudé wrote:
> > qatomic_cmpxchg__nocheck(), qatomic_read__nocheck(),
> > qatomic_set__nocheck() are defined in "qemu/atomic.h".
> > Include it in order to avoid:
> >
> >    In file included from include/exec/helper-proto.h:10:
> >    In file included from include/exec/helper-proto-common.h:10:
> >    In file included from include/qemu/atomic128.h:61:
> >    In file included from host/include/aarch64/host/atomic128-cas.h:16:
> >    host/include/generic/host/atomic128-cas.h:23:11: error: call to 
> > undeclared function 'qatomic_cmpxchg__nocheck'; ISO C99 and later do 
> > not support implicit function declarations 
> > [-Wimplicit-function-declaration]
> >      r.i = qatomic_cmpxchg__nocheck(ptr_align, c.i, n.i);
>
>
> Nak.  We can rename these host/include/*/host/*atomic* as .h.inc if you 
> need, but the top-level header is include/qemu/atomic128.h.

Patch available here:
20240418160943.95047-3-philmd@linaro.org/">https://lore.kernel.org/qemu-devel/20240418160943.95047-3-philmd@linaro.org/