[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 08/18] virtio-net: Add only one queue pair when realizing
From: |
Akihiko Odaki |
Subject: |
[PATCH v10 08/18] virtio-net: Add only one queue pair when realizing |
Date: |
Sun, 28 Apr 2024 16:00:51 +0900 |
Multiqueue usage is not negotiated yet when realizing. If more than
one queue is added and the guest never requests to enable multiqueue,
the extra queues will not be deleted when unrealizing and leak.
Fixes: f9d6dbf0bf6e ("virtio-net: remove virtio queues if the guest doesn't
support multiqueue")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/net/virtio-net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 8ede38aadbbe..e33bdbfd84a5 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3759,9 +3759,7 @@ static void virtio_net_device_realize(DeviceState *dev,
Error **errp)
n->net_conf.tx_queue_size = MIN(virtio_net_max_tx_queue_size(n),
n->net_conf.tx_queue_size);
- for (i = 0; i < n->max_queue_pairs; i++) {
- virtio_net_add_queue(n, i);
- }
+ virtio_net_add_queue(n, 0);
n->ctrl_vq = virtio_add_queue(vdev, 64, virtio_net_handle_ctrl);
qemu_macaddr_default_if_unset(&n->nic_conf.macaddr);
--
2.44.0
- [PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements, Akihiko Odaki, 2024/04/28
- [PATCH v10 01/18] tap: Remove tap_probe_vnet_hdr_len(), Akihiko Odaki, 2024/04/28
- [PATCH v10 02/18] tap: Remove qemu_using_vnet_hdr(), Akihiko Odaki, 2024/04/28
- [PATCH v10 03/18] net: Move virtio-net header length assertion, Akihiko Odaki, 2024/04/28
- [PATCH v10 04/18] net: Remove receive_raw(), Akihiko Odaki, 2024/04/28
- [PATCH v10 05/18] tap: Call tap_receive_iov() from tap_receive(), Akihiko Odaki, 2024/04/28
- [PATCH v10 06/18] tap: Shrink zeroed virtio-net header, Akihiko Odaki, 2024/04/28
- [PATCH v10 07/18] virtio-net: Do not propagate ebpf-rss-fds errors, Akihiko Odaki, 2024/04/28
- [PATCH v10 08/18] virtio-net: Add only one queue pair when realizing,
Akihiko Odaki <=
- [PATCH v10 09/18] virtio-net: Copy header only when necessary, Akihiko Odaki, 2024/04/28
- [PATCH v10 10/18] virtio-net: Shrink header byte swapping buffer, Akihiko Odaki, 2024/04/28
- [PATCH v10 11/18] virtio-net: Disable RSS on reset, Akihiko Odaki, 2024/04/28
- [PATCH v10 13/18] virtio-net: Always set populate_hash, Akihiko Odaki, 2024/04/28
- [PATCH v10 14/18] virtio-net: Do not write hashes to peer buffer, Akihiko Odaki, 2024/04/28
- [PATCH v10 12/18] virtio-net: Unify the logic to update NIC state for RSS, Akihiko Odaki, 2024/04/28
- [PATCH v10 17/18] ebpf: Refactor tun_rss_steering_prog(), Akihiko Odaki, 2024/04/28
- [PATCH v10 15/18] ebpf: Fix RSS error handling, Akihiko Odaki, 2024/04/28
- [PATCH v10 16/18] ebpf: Return 0 when configuration fails, Akihiko Odaki, 2024/04/28
- [PATCH v10 18/18] ebpf: Add a separate target for skeleton, Akihiko Odaki, 2024/04/28