Re: [PATCH v3 4/4] qapi: introduce exit-on-error parameter for migrate-incoming

[Vladimir Sementsov-Ogievskiy]

On 29.04.24 16:06, Fabiano Rosas wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
>
> > On 25.04.24 23:30, Fabiano Rosas wrote:
> > > > @@ -797,13 +801,18 @@ fail:
> > > >                          MIGRATION_STATUS_FAILED);
> > > >        migration_incoming_state_destroy();
> > > >    
> > > > -    if (migrate_has_error(s)) {
> > > > -        WITH_QEMU_LOCK_GUARD(&s->error_mutex) {
> > > > -            error_report_err(s->error);
> > > > +    if (mis->exit_on_error) {
> > > > +        if (migrate_has_error(s)) {
> > > > +            WITH_QEMU_LOCK_GUARD(&s->error_mutex) {
> > > > +                error_report_err(s->error);
> > > error_report_err(error_copy(s->error))
> > >
> > > ...because later on you're reading from s->error at
> > > fill_destination_migration_info.
> >
> > No, we immediately do exit() instead. That's just a preexisting behavior, moved into 
> > "if (mis->exit_on_error)"
>
> I meant later in the patch, not later in the execution. Can't
> query-migrate be called during process_incoming_migration_co?

Hmm.. On the one hand, seems no reason to care about it exactly before exit().. 
On the other hand, we do care about taking error_mutex. And we do release it, 
which may trigger another critical section.

I'll try to touch up this thing.

--
Best regards,
Vladimir