[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [RFC] tcg/ppc: Do not overwrite lower addres
From: |
Andreas Färber |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [RFC] tcg/ppc: Do not overwrite lower address word on Darwin and AIX |
Date: |
Sun, 06 May 2012 22:03:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 06.05.2012 21:38, schrieb Andreas Färber:
> For targets where TARGET_LONG_BITS != 32, i.e. 64-bit guests,
> addr_reg is moved to r4. For hosts with TCG_TARGET_CALL_ALIGN_ARGS
Er, obviously I meant "without". :)
/-F
> either data_reg2 or data_reg or a masked version thereof would overwrite
> r4. Place it in r5 instead, matching TCG_TARGET_CALL_ALIGN_ARGS hosts.
>
> This might explain crashes observed on Darwin/ppc but not on ppc64.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> tcg/ppc/tcg-target.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c
> index dc40716..4b85c89 100644
> --- a/tcg/ppc/tcg-target.c
> +++ b/tcg/ppc/tcg-target.c
> @@ -816,11 +816,7 @@ static void tcg_out_qemu_st (TCGContext *s, const TCGArg
> *args, int opc)
> #else
> tcg_out_mov (s, TCG_TYPE_I32, 3, addr_reg2);
> tcg_out_mov (s, TCG_TYPE_I32, 4, addr_reg);
> -#ifdef TCG_TARGET_CALL_ALIGN_ARGS
> ir = 5;
> -#else
> - ir = 4;
> -#endif
> #endif
>
> switch (opc) {