[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fix
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN |
Date: |
Thu, 18 Oct 2012 08:37:20 +0200 |
On 18.10.2012, at 07:50, David Gibson <address@hidden> wrote:
> Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models
> to represent a TLB entry contains a target_phys_addr_t. That works
> reasonably for now, but is troublesome for saving the state, which we'll
> want to do in future. target_phys_addr_t is a large enough type to contain
> a physical address for any supported machine - and can thus, in theory at
> least, vary depending on what machines are enabled other than the one
> we're actually using right now. This makes it unsuitable for describing
> in vmstate.
Target_phys_addr_t is actually 64bit for all ppc targets today since some 32
bit boards support more than 32 bit address space ;).
The change still is fine though, as it makes that bit explicit.
Alex
>
> This patch therefore changes ppcemb_tlb_t to use a fixed 64-bit integer
> which we know is sufficient for all the machines which use this structure.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> target-ppc/cpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index cde6da0..f30e0c7 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -355,7 +355,7 @@ struct ppc6xx_tlb_t {
>
> typedef struct ppcemb_tlb_t ppcemb_tlb_t;
> struct ppcemb_tlb_t {
> - target_phys_addr_t RPN;
> + uint64_t RPN;
> target_ulong EPN;
> target_ulong PID;
> target_ulong size;
> --
> 1.7.10.4
>
- [Qemu-ppc] [0/15] pseries patch queue, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 09/15] pseries: Return the token when we register an RTAS call, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 10/15] pseries: Allow RTAS tokens without a qemu handler, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 01/15] pseries: Don't allow duplicate registration of hcalls or RTAS calls, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 05/15] pseries: Clean up inconsistent variable name in xics.c, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 11/15] pseries: Add tracepoints to the XICS interrupt controller, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 02/15] target-ppc: Rework storage of VPA registration state, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 06/15] pseries: Use #define for XICS base irq number, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 12/15] pseries: Split xics irq configuration from state information, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/10/18
- Re: [Qemu-ppc] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN,
Alexander Graf <=
- [Qemu-ppc] [PATCH 08/15] pseries: Move XICS initialization before cpu initialization, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 07/15] pseries: Cleanup duplications of ics_valid_irq() code, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 03/15] pseries: Implement qemu initiated shutdowns using EPOW events, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 14/15] pseries: Implement PAPR NVRAM, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 04/15] target-ppc: Extend FPU state for newer POWER CPUs, David Gibson, 2012/10/18
- [Qemu-ppc] [PATCH 15/15] pseries: Update SLOF for NVRAM support, David Gibson, 2012/10/18