[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 05/16] pseries: Use #define for XICS base irq numb
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 05/16] pseries: Use #define for XICS base irq number |
Date: |
Fri, 2 Nov 2012 13:12:32 +1100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 01, 2012 at 11:15:43AM +0100, Alexander Graf wrote:
>
> On 30.10.2012, at 04:25, David Gibson wrote:
>
> > From: Ben Herrenschmidt <address@hidden>
> >
> > Currently the lowest "real" irq number for the XICS irq controller (as
> > opposed to numbers reserved for IPIs and other special purposes) is
> > hard coded as 16 in two places - in xics_system_init() and in spapr.c.
> >
> > As well as being generally bad practice, we're going to need to change this
> > number soon to fit in with the in-kernel XICS implementation. This patch
> > adds a #define for this number to avoid future breakage.
> >
> > Signed-off-by: Michael Ellerman <address@hidden>
> > Signed-off-by: Ben Herrenschmidt <address@hidden>
>
> From: and Signed-off fields seem to not match.
Well.. it's a fuzzy case in signed-off practice. Both Michael and Ben
have worked on the patch, Michael first. I then split the patch up
for submission and had to make a judgement call as to who was the main
author of that section. My best guess on the available information
was Ben.
Michael, Ben, have anything to add?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson