[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 19/21] MSI-X: Fix endianness
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 19/21] MSI-X: Fix endianness |
Date: |
Thu, 13 Dec 2012 13:02:26 +0100 |
The MSI-X vector tables are usually stored in little endian in memory,
so let's mark the accessors as such.
This fixes MSI-X on e500 for me.
Signed-off-by: Alexander Graf <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
---
hw/msix.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/msix.c b/hw/msix.c
index 136ef09..b57ae60 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -180,8 +180,7 @@ static void msix_table_mmio_write(void *opaque, hwaddr addr,
static const MemoryRegionOps msix_table_mmio_ops = {
.read = msix_table_mmio_read,
.write = msix_table_mmio_write,
- /* TODO: MSIX should be LITTLE_ENDIAN. */
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
.valid = {
.min_access_size = 4,
.max_access_size = 4,
@@ -198,8 +197,7 @@ static uint64_t msix_pba_mmio_read(void *opaque, hwaddr
addr,
static const MemoryRegionOps msix_pba_mmio_ops = {
.read = msix_pba_mmio_read,
- /* TODO: MSIX should be LITTLE_ENDIAN. */
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
.valid = {
.min_access_size = 4,
.max_access_size = 4,
--
1.6.0.2
- [Qemu-ppc] [PATCH 00/21] OpenPIC refactoring and MSI support v3, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 08/21] openpic: combine openpic and mpic reset functions, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 04/21] openpic: combine mpic and openpic src handlers, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 01/21] openpic: Remove unused code, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 06/21] openpic: combine mpic and openpic irq raise functions, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 12/21] openpic: rename openpic_t to OpenPICState, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 07/21] openpic: merge mpic and openpic timer handling, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 05/21] openpic: Convert subregions to memory api, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 19/21] MSI-X: Fix endianness,
Alexander Graf <=
- [Qemu-ppc] [PATCH 11/21] openpic: convert simple reg operations to builtin bitops, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 10/21] openpic: remove unused type variable, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 09/21] openpic: unify memory api subregions, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 18/21] PPC: e500: Declare pci bridge as bridge, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 15/21] openpic: make brr1 model specific, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 03/21] openpic: update to proper memory api, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 16/21] openpic: add Shared MSI support, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 02/21] mpic: Unify numbering scheme, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 17/21] PPC: e500: Add MSI support, Alexander Graf, 2012/12/13
- [Qemu-ppc] [PATCH 14/21] openpic: convert to qdev, Alexander Graf, 2012/12/13