[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 2/3] Reset qemu timers when guest reset
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [PATCH 2/3] Reset qemu timers when guest reset |
Date: |
Mon, 17 Dec 2012 16:13:16 +0100 |
On 17.12.2012, at 16:09, Bhushan Bharat-R65777 wrote:
>
>
>> -----Original Message-----
>> From: Alexander Graf [mailto:address@hidden
>> Sent: Monday, December 17, 2012 7:53 PM
>> To: Bhushan Bharat-R65777
>> Cc: address@hidden; address@hidden; Bhushan Bharat-R65777
>> Subject: Re: [PATCH 2/3] Reset qemu timers when guest reset
>>
>>
>> On 17.12.2012, at 07:08, Bharat Bhushan wrote:
>>
>>> This patch install the timer reset handler. This will be called when
>>> the guest is reset.
>>>
>>> Signed-off-by: Bharat Bhushan <address@hidden>
>>> ---
>>> hw/ppc_booke.c | 12 ++++++++++++
>>> 1 files changed, 12 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/ppc_booke.c b/hw/ppc_booke.c index d51e7fa..837a5b6
>>> 100644
>>> --- a/hw/ppc_booke.c
>>> +++ b/hw/ppc_booke.c
>>> @@ -231,6 +231,16 @@ void store_booke_tcr(CPUPPCState *env,
>>> target_ulong val)
>>>
>>> }
>>>
>>> +static void ppc_booke_timer_reset_handle(void *opaque) {
>>> + CPUPPCState *env = opaque;
>>> +
>>
>> Doesn't this need a cpu_synchronize_state() call?
>
> There are some more registered reset_handler which changes the spr's but does
> not call synchronize..
>
> But is not the qemu_system_reset() ( which calls registered reset handler)
> synchronizes the cpu state ?
Probably :). Just wanted to make sure it's left out on purpose.
Alex