[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified ID
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified IDE, and clean up |
Date: |
Tue, 18 Dec 2012 07:35:01 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Markus Armbruster <address@hidden> writes:
> *** Important ***
> This *breaks* all non-qdevified controllers, see PATCH 01/10.
> Maintainers are cc'ed.
>
> If you want still more time to qdevify your controller, please speak
> up now, and tell us how much.
>
> The rest of the series is obvious cleanups enabled by dropping the
> special case of a non-qdevified controller. The block configuration
> stuff I'm working on also profits from it, and is real reason I'm
> posting this.
Breaking is not the right approach. If you're asserting that the code
is unused and unloved, then remove it entirely from the tree.
Just breaking something is always wrong though.
I only see three users of ide_init2_with_non_qdev_drives. Is there any
reason you didn't just convert these users to qdev?
Regards,
Anthony Liguori
>
> Markus Armbruster (10):
> ide: Break all non-qdevified controllers
> ide: Move IDEDevice pointer from IDEBus to IDEState
> ide: Use IDEState member dev for "device connected" test
> ide: Don't block-align IDEState member smart_selftest_data
> ide: Drop redundant IDEState member bs
> ide: Drop redundant IDEState geometry members
> ide: Drop redundant IDEState member version
> ide: Drop redundant IDEState member drive_serial_str
> ide: Drop redundant IDEState member model
> ide: Drop redundant IDEState member wwn
>
> hw/ide/ahci.c | 19 ++--
> hw/ide/atapi.c | 39 ++++----
> hw/ide/core.c | 278
> +++++++++++++++++++++-------------------------------
> hw/ide/internal.h | 15 +--
> hw/ide/macio.c | 20 ++--
> hw/ide/microdrive.c | 5 +-
> hw/ide/piix.c | 1 -
> hw/ide/qdev.c | 50 +++++-----
> 8 files changed, 189 insertions(+), 238 deletions(-)
>
> --
> 1.7.11.7
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers, (continued)
[Qemu-ppc] [PATCH 03/10] ide: Use IDEState member dev for "device connected" test, Markus Armbruster, 2012/12/17
[Qemu-ppc] [PATCH 10/10] ide: Drop redundant IDEState member wwn, Markus Armbruster, 2012/12/17
[Qemu-ppc] [PATCH 07/10] ide: Drop redundant IDEState member version, Markus Armbruster, 2012/12/17
[Qemu-ppc] [PATCH 06/10] ide: Drop redundant IDEState geometry members, Markus Armbruster, 2012/12/17
[Qemu-ppc] [PATCH 09/10] ide: Drop redundant IDEState member model, Markus Armbruster, 2012/12/17
[Qemu-ppc] [PATCH 04/10] ide: Don't block-align IDEState member smart_selftest_data, Markus Armbruster, 2012/12/17
[Qemu-ppc] [PATCH 08/10] ide: Drop redundant IDEState member drive_serial_str, Markus Armbruster, 2012/12/17
[Qemu-ppc] [PATCH 05/10] ide: Drop redundant IDEState member bs, Markus Armbruster, 2012/12/17
Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified IDE, and clean up,
Anthony Liguori <=