[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 04/30] target-ppc: fix nego and subf*o instructions
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 04/30] target-ppc: fix nego and subf*o instructions |
Date: |
Fri, 26 Apr 2013 20:21:23 +0200 |
From: Aurelien Jarno <address@hidden>
The overflow computation of nego and subf*o instructions has been broken
in commit ffe30937. Contrary to other targets, the instruction is subtract
from an not subtract on PowerPC.
This patch fixes the issue by using the correct argument in the xor
computation. Thanks to Peter Maydell for the hint.
With this change the PPC emulation passes the Gwenole Beauchesne
testsuite again.
Signed-off-by: Aurelien Jarno <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
target-ppc/translate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 5e741d1..294ab58 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -746,7 +746,7 @@ static inline void gen_op_arith_compute_ov(DisasContext
*ctx, TCGv arg0,
{
TCGv t0 = tcg_temp_new();
- tcg_gen_xor_tl(cpu_ov, arg0, arg1);
+ tcg_gen_xor_tl(cpu_ov, arg0, arg2);
tcg_gen_xor_tl(t0, arg1, arg2);
if (sub) {
tcg_gen_and_tl(cpu_ov, cpu_ov, t0);
--
1.6.0.2
- [Qemu-ppc] [PULL 00/30] ppc patch queue 2013-04-26, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 01/30] target-ppc: Enable ISEL on POWER7, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 08/30] linux-headers: Update to kvm/queue, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 02/30] PPC: e500: advertise 4.2 MPIC only if KVM supports EPR, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 04/30] target-ppc: fix nego and subf*o instructions,
Alexander Graf <=
- [Qemu-ppc] [PATCH 06/30] PPC: Add breakpoint registers for 603 and e300, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 10/30] PPC: mac newworld: fix cpu NIP reset value, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 07/30] target-ppc: Fix narrow-mode add/sub carry output, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 11/30] PPC: Fix compile with profiling enabled, Alexander Graf, 2013/04/26
- [Qemu-ppc] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450, Alexander Graf, 2013/04/26
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450, Andreas Färber, 2013/04/28
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450, Fabien Chouteau, 2013/04/29
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450, Andreas Färber, 2013/04/29
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/30] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450, Aurelien Jarno, 2013/04/29
- [Qemu-ppc] [PATCH] Fix PReP NIP reset value, Fabien Chouteau, 2013/04/30