[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 2/2] PPC: Fail on leaking temporaries
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 2/2] PPC: Fail on leaking temporaries |
Date: |
Sun, 19 Jan 2014 17:32:16 +0100 |
When QEMU gets compiled with --enable-debug-tcg we can check for temporary
leakage. Implement the necessary target code for this and fail emulation
when we hit a leakage.
This hopefully ensures that we don't get new leaks.
Signed-off-by: Alexander Graf <address@hidden>
---
target-ppc/translate.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 02cd18e..759133c 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -10412,6 +10412,7 @@ static inline void
gen_intermediate_code_internal(PowerPCCPU *cpu,
max_insns = CF_COUNT_MASK;
gen_tb_start();
+ tcg_clear_temp_count();
/* Set env in case of segfault during code fetch */
while (ctx.exception == POWERPC_EXCP_NONE
&& tcg_ctx.gen_opc_ptr < gen_opc_end) {
@@ -10511,6 +10512,12 @@ static inline void
gen_intermediate_code_internal(PowerPCCPU *cpu,
*/
break;
}
+ if (tcg_check_temp_count()) {
+ fprintf(stderr, "Opcode %02x %02x %02x (%08x) leaked
temporaries\n",
+ opc1(ctx.opcode), opc2(ctx.opcode), opc3(ctx.opcode),
+ ctx.opcode);
+ exit(1);
+ }
}
if (tb->cflags & CF_LAST_IO)
gen_io_end();
--
1.8.1.4
- [Qemu-ppc] [PATCH 0/2] PPC: Check for temporary leakage, Alexander Graf, 2014/01/19
- [Qemu-ppc] [PATCH 1/2] PPC: Fix TCG chunks that don't free their temps, Alexander Graf, 2014/01/19
- [Qemu-ppc] [PATCH 2/2] PPC: Fail on leaking temporaries,
Alexander Graf <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] PPC: Fail on leaking temporaries, Peter Maydell, 2014/01/19
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] PPC: Fail on leaking temporaries, Alexander Graf, 2014/01/19
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] PPC: Fail on leaking temporaries, Peter Maydell, 2014/01/19
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] PPC: Fail on leaking temporaries, Alexander Graf, 2014/01/19
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] PPC: Fail on leaking temporaries, Peter Maydell, 2014/01/19
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] PPC: Fail on leaking temporaries, Alexander Graf, 2014/01/19