[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor
From: |
Eric Blake |
Subject: |
Re: [Qemu-ppc] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor |
Date: |
Mon, 17 Feb 2014 09:36:11 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/17/2014 08:49 AM, Igor Mammedov wrote:
> From: Wanlong Gao <address@hidden>
>
> Signed-off-by: Wanlong Gao <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -4420,3 +4420,35 @@
> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node. (for OptsVisitor)
> +#
> +# @nodeid: #optional NUMA node ID (increase by 1 from 0 if omitted)
> +#
> +# @cpus: #optional VCPUs belong to this node (assign VCPUS round-robin
s/belong/belonging/
> +# if omitted)
> +#
> +# @mem: #optional memory size of this node (go halves total memory to
> +# each node if omitted)
Awkward grammar. I suggest:
#optional memory size of this node (equally divide total memory among
nodes if omitted)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH 0/6] convert -numa to QemuOpts/OptsVisitor, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor, Igor Mammedov, 2014/02/17
- Re: [Qemu-ppc] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor,
Eric Blake <=
- [Qemu-ppc] [PATCH 1/6] vl.c: fix style issue, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 4/6] NUMA: Add numa_info structure to contain numa nodes info, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 3/6] NUMA: check if the total numa memory size is equal to ram_size, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 6/6] NUMA: expand MAX_NODES from 64 to 128, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 2/6] NUMA: move numa related code to new file numa.c, Igor Mammedov, 2014/02/17