[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine
From: |
Scott Wood |
Subject: |
Re: [Qemu-ppc] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine |
Date: |
Thu, 20 Feb 2014 09:59:15 -0600 |
On Thu, 2014-02-20 at 13:52 +0100, Alexander Graf wrote:
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c
> index 3e99b07..51f2085 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu.c
> @@ -272,6 +272,7 @@ int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char
> * const argv[])
> #ifndef CONFIG_SYS_FSL_TBCLK_DIV
> #define CONFIG_SYS_FSL_TBCLK_DIV 8
> #endif
> +__attribute__((weak))
> unsigned long get_tbclk (void)
> {
> unsigned long tbclk_div = CONFIG_SYS_FSL_TBCLK_DIV;
It's not a big deal, but we do have __weak available.
> +static void map_fdt_as(int esel)
> +{
> + u32 mas0, mas1, mas2, mas3, mas7;
> + uint64_t fdt_phys = get_fdt_phys();
> + unsigned long fdt_phys_tlb = fdt_phys & ~0xffffful;
> + unsigned long fdt_virt_tlb = (ulong)get_fdt_virt() & ~0xffffful;
> +
> + mas0 = MAS0_TLBSEL(1) | MAS0_ESEL(10);
Shouldn't you use the esel parameter here?
-Scott
- [Qemu-ppc] [PATCH v4 0/6] PPC 85xx: Add support for QEMU's ppce500 PV machine, Alexander Graf, 2014/02/20
- [Qemu-ppc] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine, Alexander Graf, 2014/02/20
- Re: [Qemu-ppc] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine,
Scott Wood <=
- [Qemu-ppc] [PATCH v4 3/6] PPC: 85xx: Remove IVOR reset, Alexander Graf, 2014/02/20
- [Qemu-ppc] [PATCH v4 2/6] fdt_support: Add helper function to read "ranges" property, Alexander Graf, 2014/02/20
- [Qemu-ppc] [PATCH v4 4/6] PPC: 85xx: Generalize DDR TLB mapping function, Alexander Graf, 2014/02/20
- [Qemu-ppc] [PATCH v4 5/6] PPC 85xx: Add ELF entry point, Alexander Graf, 2014/02/20
- [Qemu-ppc] [PATCH v4 1/6] fdt_support: split fdt_getprop_u32_default, Alexander Graf, 2014/02/20