[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] spapr: skip adding usb keyboard/mouse in case of
From: |
Nikunj A Dadhania |
Subject: |
Re: [Qemu-ppc] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults |
Date: |
Fri, 04 Apr 2014 10:58:17 +0530 |
User-agent: |
Notmuch/0.17+27~gae47d61 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-redhat-linux-gnu) |
Paolo Bonzini <address@hidden> writes:
> Il 03/04/2014 21:24, Nikunj A Dadhania ha scritto:
>>> > Does libvirt use "-nodefaults -machine usb=true"? It should create the
>>> > OHCI controller separately instead of using "-machine".
>> I see it creating:
>>
>> -nodefaults -usb -device usb-kbd,id=input0 -device usb-mouse,id=input1
>>
>> And -usb is translated to adding "pci-ohci" controller for spapr
>
> Yeah, but with -nodefaults it's better to use -device directly.
I think there is special handling for this in vl.c
bool usb_enabled(bool default_usb)
{
return qemu_opt_get_bool(qemu_get_machine_opts(), "usb",
has_defaults && default_usb);
}
And spapr.c uses this:
if (usb_enabled(spapr->has_graphics)) {
pci_create_simple(phb->bus, -1, "pci-ohci");
Regards
Nikunj
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, (continued)
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Nikunj A Dadhania, 2014/04/04
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Markus Armbruster, 2014/04/04
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Paolo Bonzini, 2014/04/04
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Markus Armbruster, 2014/04/04
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Eric Blake, 2014/04/04
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Andreas Färber, 2014/04/04
Re: [Qemu-ppc] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Paolo Bonzini, 2014/04/03