[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 7/9] PPC: e500: Support dynamicall
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 7/9] PPC: e500: Support dynamically spawned sysbus devices |
Date: |
Thu, 31 Jul 2014 14:07:52 +1000 |
On Thu, Jul 31, 2014 at 12:55 AM, Peter Maydell
<address@hidden> wrote:
> On 2 July 2014 19:01, Alexander Graf <address@hidden> wrote:
>> For e500 our approach to supporting dynamically spawned sysbus devices is to
>> create a simple bus from the guest's point of view within which we map those
>> devices dynamically.
>>
>> + /* Connect sysbus device to virtual platform bus */
>> + for (i = 0; i < sbdev->num_irq; i++) {
>> + if (!sbdev->irqp[i]) {
>> + /* This IRQ is an incoming IRQ, we can't wire those here */
>
> I don't understand this comment -- sysbus IRQs are all outbound
> by definition. Lines going in to a device are GPIOs. (Ideally we
> should get rid of "sysbus IRQs" completely and just use named
> inbound GPIOs for everything.)
>
I have some patches in this area. Will post shortly cc you and Alex.
> Also, sbdev->irqp[] is private to the sysbus implementation, so
> you shouldn't be fishing about in it in the platform code.
>
And this is in the crosshairs of that work:
@@ -47,8 +49,6 @@ struct SysBusDevice {
/*< public >*/
int num_irq;
- qemu_irq irqs[QDEV_MAX_IRQ];
- qemu_irq *irqp[QDEV_MAX_IRQ];
Regards,
Peter
> thanks
> -- PMM
>
- [Qemu-ppc] [PATCH v2 0/9] Dynamic sysbus device allocation support, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 2/9] qom: macroify integer property helpers, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 4/9] qom: Add generic object property g_free helper, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 7/9] PPC: e500: Support dynamically spawned sysbus devices, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 8/9] e500: Add support for eTSEC in device tree, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 6/9] sysbus: Make devices spawnable via -device, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 9/9] PPC: Fix default config ordering and add eTSEC for ppc64, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 1/9] qom: Move property helpers to own file, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 5/9] sysbus: Add user map hints, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 3/9] qom: Expose property helpers for get/set of integers, Alexander Graf, 2014/07/02