[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 03/14] target-ppc: use separate indices for variou
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-ppc] [PATCH 03/14] target-ppc: use separate indices for various translation modes |
Date: |
Wed, 17 Sep 2014 17:50:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 17/09/2014 17:33, Richard Henderson ha scritto:
> Hum. Well, it's not that all the tlbs together that must be less than 64k,
> it's the addend of the first entry of the last tlb that must be within 64k of
> the start of env. Nit picking, but perhaps we can word the comment better.
Indeed.
> And if we choose to do something like this, this is where I'd prefer a define
> in the relevant tcg-target.h. Because you've missed ia64 and s390 that have
> positive offsets larger than 64k (21 and 19 bits, respectively).
Right, but with 16 MMU modes the maximum size is 128k, well within s390
and ia64's limits.
> But otherwise I'm ok with this as a solution.
Thanks!
Paolo