[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 f
From: |
Andreas Färber |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage |
Date: |
Mon, 30 Mar 2015 19:49:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
David,
Am 29.03.2015 um 19:53 schrieb Andreas Färber:
> Hello Markus et al.,
>
> This series attempts to fix the -device pc87312 issues you reported.
>
> I can't add alias properties for devices that don't get created before
> realize.
> Therefore this involves moving code for various ISA devices, to enable us
> to initialize the objects early for alias properties and realizing them
> as part of the composite device once the configuration is known, also fixing
> error propagation while at it. Probably needs a further iteration.
>
> Yes, it's terribly invasive, that's why the code was as it is.
> But the code movements are quite trivial, as long as no in-air conflicts
> occur.
Could you take a look whether or where these proposed ISA code movements
conflict with your ISA config series? Might we need to introduce
separate -isa headers here?
Thanks,
Andreas
>
> A follow-up would be to respin my old ISA enabled/disabled series to allow
> inactive ISADevices sitting on an ISABus.
>
> Regards,
> Andreas
>
> Cc: Markus Armbruster <address@hidden>
> Cc: Hervé Poussineau <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> Cc: John Snow <address@hidden>
>
> Andreas Färber (8):
> parallel: Factor out header for ISAParallelState struct
> pc87312: Create isa-parallel in-place and add alias par0-chardev
> property
> serial: Move ISASerialState to header
> pc87312: Create UARTs in-place and add alias properties
> fdb: Move FDCtrlISABus to header
> pc87312: Create FDC in-place
> ide: Move ISAIDEState to header
> pc87312: Create IDE in-place
>
> hw/block/fdc.c | 87 -----------------------
> hw/char/parallel.c | 30 +-------
> hw/char/serial-isa.c | 12 ----
> hw/ide/internal.h | 155 ----------------------------------------
> hw/ide/isa.c | 13 ----
> hw/isa/pc87312.c | 107 ++++++++++++++++------------
> hw/ppc/prep.c | 33 +++++++++
> include/hw/block/fdc.h | 88 +++++++++++++++++++++++
> include/hw/char/parallel.h | 62 ++++++++++++++++
> include/hw/char/serial.h | 14 ++++
> include/hw/ide.h | 173
> +++++++++++++++++++++++++++++++++++++++++++++
> include/hw/isa/pc87312.h | 23 +++---
> 12 files changed, 442 insertions(+), 355 deletions(-)
> create mode 100644 include/hw/char/parallel.h
>
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-ppc] [PATCH RFC for-2.3? 5/8] fdb: Move FDCtrlISABus to header, (continued)
- [Qemu-ppc] [PATCH RFC for-2.3? 5/8] fdb: Move FDCtrlISABus to header, Andreas Färber, 2015/03/29
- [Qemu-ppc] [PATCH RFC for-2.3? 6/8] pc87312: Create FDC in-place, Andreas Färber, 2015/03/29
- [Qemu-ppc] [PATCH RFC for-2.3? 8/8] pc87312: Create IDE in-place, Andreas Färber, 2015/03/29
- [Qemu-ppc] [PATCH RFC for-2.3? 7/8] ide: Move ISAIDEState to header, Andreas Färber, 2015/03/29
- Re: [Qemu-ppc] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage, Markus Armbruster, 2015/03/30
- Re: [Qemu-ppc] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage,
Andreas Färber <=