[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "confi
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "configured" |
Date: |
Fri, 14 Aug 2015 14:33:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
I'd like to know if it is the good way to fix the problem: are there
more comments on this patch ? People from IBM ?
Laurent
On 13/08/2015 14:53, Laurent Vivier wrote:
> When a device is hotplugged, attach() sets "configured" to
> false, waiting an action from the OS to configure it and then
> to call ibm,configure-connector. On ibm,configure-connector,
> the hypervisor sets "configured" to true.
>
> In case of coldplugged device, attach() sets "configured" to
> false, but firmware and OS never call the ibm,configure-connector
> in this case, so it remains set to false.
>
> It could be harmless, but when we unplug a device, hypervisor
> waits the device becomes configured because for it, a not configured
> device is a device being configured, so it waits the end of configuration
> to unplug it... and it never happens, so it is never unplugged.
>
> This patch set by default coldplugged device to "configured=true",
> hotplugged device to "configured=false".
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> hw/ppc/spapr_drc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index ee87432..e86babf 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -310,7 +310,7 @@ static void attach(sPAPRDRConnector *drc, DeviceState *d,
> void *fdt,
> drc->dev = d;
> drc->fdt = fdt;
> drc->fdt_start_offset = fdt_start_offset;
> - drc->configured = false;
> + drc->configured = coldplug;
>
> object_property_add_link(OBJECT(drc), "device",
> object_get_typename(OBJECT(drc->dev)),
>
Re: [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "configured",
Laurent Vivier <=