[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH v2 2/9] exec: Do vmstate unregistration from c
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [RFC PATCH v2 2/9] exec: Do vmstate unregistration from cpu_exec_exit() |
Date: |
Tue, 15 Mar 2016 17:15:10 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Mar 11, 2016 at 10:24:31AM +0530, Bharata B Rao wrote:
> cpu_exec_init() does vmstate_register for the CPU device. This needs to be
> undone from cpu_exec_exit(). This change is needed to support CPU hot
> removal.
>
> Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> exec.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/exec.c b/exec.c
> index 49ae593..8ddca6b 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -634,6 +634,8 @@ static void cpu_release_index(CPUState *cpu)
>
> void cpu_exec_exit(CPUState *cpu)
> {
> + CPUClass *cc = CPU_GET_CLASS(cpu);
> +
> #if defined(CONFIG_USER_ONLY)
> cpu_list_lock();
> #endif
> @@ -651,6 +653,13 @@ void cpu_exec_exit(CPUState *cpu)
> #if defined(CONFIG_USER_ONLY)
> cpu_list_unlock();
> #endif
> +
> + if (cc->vmsd != NULL) {
> + vmstate_unregister(NULL, cc->vmsd, cpu);
> + }
> + if (qdev_get_vmsd(DEVICE(cpu)) == NULL) {
> + vmstate_unregister(NULL, &vmstate_cpu_common, cpu);
> + }
> }
>
> void cpu_exec_init(CPUState *cpu, Error **errp)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR, Bharata B Rao, 2016/03/10
- [Qemu-ppc] [RFC PATCH v2 1/9] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2016/03/10
- [Qemu-ppc] [RFC PATCH v2 2/9] exec: Do vmstate unregistration from cpu_exec_exit(), Bharata B Rao, 2016/03/10
- [Qemu-ppc] [RFC PATCH v2 4/9] cpu: Add a sync version of cpu_remove(), Bharata B Rao, 2016/03/10
- [Qemu-ppc] [RFC PATCH v2 3/9] cpu: Reclaim vCPU objects, Bharata B Rao, 2016/03/10
- [Qemu-ppc] [RFC PATCH v2 6/9] spapr: CPU core device, Bharata B Rao, 2016/03/10