[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v1 05/11] ppc/xics: Replace "icp" with "xics" in m
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v1 05/11] ppc/xics: Replace "icp" with "xics" in most places |
Date: |
Mon, 27 Jun 2016 13:43:42 +1000 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, Jun 23, 2016 at 11:17:24PM +0530, Nikunj A Dadhania wrote:
> From: Benjamin Herrenschmidt <address@hidden>
>
> The "ICP" is a different object than the "XICS". For historical reasons,
> we have a number of places where we name a variable "icp" while it contains
> a XICSState pointer. There *is* an ICPState structure too so this makes
> the code really confusing.
>
> This is a mechanical replacement of all those instances to use the name
> "xics" instead. There should be no functional change.
>
> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
> [spapr_cpu_init has been moved to spapr_cpu_core.c, change there]
> Signed-off-by: Nikunj A Dadhania <address@hidden>
Reviewed-by: David Gibson <address@hidden>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [PATCH v1 01/11] ppc/xics: Rename existing xics to xics_spapr, (continued)
- [Qemu-ppc] [PATCH v1 03/11] ppc/xics: Implement H_IPOLL using an accessor, Nikunj A Dadhania, 2016/06/23
- [Qemu-ppc] [PATCH v1 04/11] ppc/xics: Remove unused xics_set_irq_type(), Nikunj A Dadhania, 2016/06/23
- [Qemu-ppc] [PATCH v1 05/11] ppc/xics: Replace "icp" with "xics" in most places, Nikunj A Dadhania, 2016/06/23
- Re: [Qemu-ppc] [PATCH v1 05/11] ppc/xics: Replace "icp" with "xics" in most places,
David Gibson <=
- [Qemu-ppc] [PATCH v1 06/11] ppc/xics: Make the ICSState a list, Nikunj A Dadhania, 2016/06/23
- Re: [Qemu-ppc] [PATCH v1 06/11] ppc/xics: Make the ICSState a list, Nikunj A Dadhania, 2016/06/27
[Qemu-ppc] [PATCH v1 07/11] ppc/xics: An ICS with offset 0 is assumed to be uninitialized, Nikunj A Dadhania, 2016/06/23
[Qemu-ppc] [PATCH v1 08/11] ppc/xics: Use a helper to add a new ICS, Nikunj A Dadhania, 2016/06/23
[Qemu-ppc] [PATCH v1 11/11] ppc/xics: Add xics to the monitor "info pic" command, Nikunj A Dadhania, 2016/06/23