[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_
From: |
Bharata B Rao |
Subject: |
Re: [Qemu-ppc] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_release() |
Date: |
Thu, 30 Jun 2016 09:59:43 +0530 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jun 29, 2016 at 10:50:45PM +0200, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> hw/ppc/spapr_cpu_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> index 2615058da745..a15dc010626d 100644
> --- a/hw/ppc/spapr_cpu_core.c
> +++ b/hw/ppc/spapr_cpu_core.c
> @@ -101,9 +101,8 @@ static void spapr_core_release(DeviceState *dev, void
> *opaque)
> sPAPRCPUCore *sc = SPAPR_CPU_CORE(OBJECT(dev));
> const char *typename = object_class_get_name(sc->cpu_class);
> size_t size = object_type_get_instance_size(typename);
> sPAPRMachineState *spapr = SPAPR_MACHINE(qdev_get_machine());
> - sPAPRCPUCore *core = SPAPR_CPU_CORE(OBJECT(dev));
> CPUCore *cc = CPU_CORE(dev);
> int smt = kvmppc_smt_threads();
> int i;
>
> @@ -119,9 +118,9 @@ static void spapr_core_release(DeviceState *dev, void
> *opaque)
> }
>
> spapr->cores[cc->core_id / smt] = NULL;
>
> - g_free(core->threads);
> + g_free(sc->threads);
> object_unparent(OBJECT(dev));
> }
>
> void spapr_core_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
Reviewed-by: Bharata B Rao <address@hidden>
- [Qemu-ppc] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code, Greg Kurz, 2016/06/29
- [Qemu-ppc] [PATCH 1/8] spapr: drop reference on child object during core realization, Greg Kurz, 2016/06/29
- [Qemu-ppc] [PATCH 2/8] spapr: do proper error propagation in spapr_cpu_core_realize_child(), Greg Kurz, 2016/06/29
- [Qemu-ppc] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_release(), Greg Kurz, 2016/06/29
- Re: [Qemu-ppc] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_release(),
Bharata B Rao <=
- [Qemu-ppc] [PATCH 4/8] exec: add missing conditional compilation, Greg Kurz, 2016/06/29
- [Qemu-ppc] [PATCH 5/8] exec: move cpu_index init and exit to their own function, Greg Kurz, 2016/06/29
- [Qemu-ppc] [PATCH 6/8] ppc: move cpu index setup to instance_init/finalize, Greg Kurz, 2016/06/29
- [Qemu-ppc] [PATCH 7/8] cpu: add initialization helper without realize, Greg Kurz, 2016/06/29
- [Qemu-ppc] [PATCH 8/8] hw/ppc: move DT cpu id generation to machine code, Greg Kurz, 2016/06/29
- Re: [Qemu-ppc] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code, Greg Kurz, 2016/06/29
- Re: [Qemu-ppc] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code, David Gibson, 2016/06/30
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code, Igor Mammedov, 2016/06/30