[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 07/15] target-ppc: implement branch-less divw[o
From: |
Nikunj A Dadhania |
Subject: |
Re: [Qemu-ppc] [PATCH v3 07/15] target-ppc: implement branch-less divw[o][.] |
Date: |
Tue, 26 Jul 2016 07:22:18 +0530 |
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
Richard Henderson <address@hidden> writes:
> On 07/25/2016 10:50 PM, Nikunj A Dadhania wrote:
>> if (compute_ov) {
>> - tcg_gen_movi_tl(cpu_ov, 1);
>> - tcg_gen_movi_tl(cpu_so, 1);
>> + tcg_gen_extu_i32_tl(cpu_ov, t2);
>> + tcg_gen_extu_i32_tl(cpu_so, t2);
>> }
>
> This should be
>
> tcg_gen_extu_i32_tl(cpu_ov, t2);
> tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);
>
> I.e. the summary overflow accumulates.
Sure, i missed that bit. In the previous case it was always setting it
to 1, because an overflow had occurred. And not changing it otherwise.
Regards
Nikunj
- [Qemu-ppc] [PATCH v3 01/15] target-ppc: Introduce Power9 family, (continued)
- [Qemu-ppc] [PATCH v3 01/15] target-ppc: Introduce Power9 family, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 02/15] target-ppc: Introduce POWER ISA 3.0 flag, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 03/15] target-ppc: adding addpcis instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 04/15] target-ppc: add cmprb instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 05/15] target-ppc: add modulo word operations, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 06/15] target-ppc: add modulo dword operations, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 07/15] target-ppc: implement branch-less divw[o][.], Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 08/15] target-ppc: implement branch-less divd[o][.], Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 09/15] target-ppc: add cnttzd[.] instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 10/15] target-ppc: add cnttzw[.] instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 11/15] target-ppc: add cmpeqb instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 12/15] target-ppc: add setb instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 13/15] target-ppc: add maddld instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 14/15] target-ppc: add maddhd and maddhdu instruction, Nikunj A Dadhania, 2016/07/25
- [Qemu-ppc] [PATCH v3 15/15] target-ppc: introduce opc4 for Expanded Opcode, Nikunj A Dadhania, 2016/07/25