[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 4/7] ppc/pnv: add a core mask to PnvChip
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-ppc] [PATCH v2 4/7] ppc/pnv: add a core mask to PnvChip |
Date: |
Fri, 2 Sep 2016 10:03:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 08/31/2016 06:34 PM, Cédric Le Goater wrote:
> This will be used to build real HW ids for the cores and enforce some
> limits on the available cores per chip.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
> hw/ppc/pnv.c | 27 +++++++++++++++++++++++++++
> include/hw/ppc/pnv.h | 2 ++
> 2 files changed, 29 insertions(+)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index a6e7f66b2c0a..b6efb5e3ef07 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -236,6 +236,27 @@ static void ppc_powernv_init(MachineState *machine)
> g_free(chip_typename);
> }
>
> +/* Allowed core identifiers on a POWER8 Processor Chip :
> + *
> + * <EX0 reserved>
> + * EX1 - Venice only
> + * EX2 - Venice only
> + * EX3 - Venice only
> + * EX4
> + * EX5
> + * EX6
> + * <EX7,8 reserved> <reserved>
> + * EX9 - Venice only
> + * EX10 - Venice only
> + * EX11 - Venice only
> + * EX12
> + * EX13
> + * EX14
> + * <EX15 reserved>
> + */
> +#define POWER8E_CORE_MASK (~0xffff8f8f)
> +#define POWER8_CORE_MASK (~0xffff8181)
> +
> static void pnv_chip_power8nvl_realize(PnvChip *chip, Error **errp)
> {
> ;
> @@ -250,6 +271,8 @@ static void pnv_chip_power8nvl_class_init(ObjectClass
> *klass, void *data)
> k->cpu_model = "POWER8NVL";
> k->chip_type = PNV_CHIP_P8NVL;
> k->chip_f000f = 0x120d304980000000ull;
> + k->cores_max = 12;
> + k->cores_mask = POWER8_CORE_MASK;
> dc->desc = "PowerNV Chip POWER8NVL";
> }
>
> @@ -274,6 +297,8 @@ static void pnv_chip_power8_class_init(ObjectClass
> *klass, void *data)
> k->cpu_model = "POWER8";
> k->chip_type = PNV_CHIP_P8;
> k->chip_f000f = 0x220ea04980000000ull;
> + k->cores_max = 12;
> + k->cores_mask = POWER8_CORE_MASK;
> dc->desc = "PowerNV Chip POWER8";
> }
>
> @@ -298,6 +323,8 @@ static void pnv_chip_power8e_class_init(ObjectClass
> *klass, void *data)
> k->cpu_model = "POWER8E";
> k->chip_type = PNV_CHIP_P8E;
> k->chip_f000f = 0x221ef04980000000ull;
> + k->cores_max = 6;
> + k->cores_mask = POWER8E_CORE_MASK;
> dc->desc = "PowerNV Chip POWER8E";
> }
>
> diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h
> index bc6e1f80096b..987bc70245a7 100644
> --- a/include/hw/ppc/pnv.h
> +++ b/include/hw/ppc/pnv.h
> @@ -49,6 +49,8 @@ typedef struct PnvChipClass {
> /*< private >*/
> SysBusDeviceClass parent_class;
> /*< public >*/
> + uint32_t cores_max;
> + uint32_t cores_mask;
This 'cores_mask' attribute needs to be a uint64_t for POWER9. The
core chiplet ids are in the range : [ 0x20 - 0x37 ]
I will change that in the next version and include a PnvChipPower9
class as the cpu_model was merged in David's branch.
Cheers,
C.
- Re: [Qemu-ppc] [PATCH v2 4/7] ppc/pnv: add a core mask to PnvChip,
Cédric Le Goater <=